From 3fa0b02560445f78e44cc89304b961025efd794d Mon Sep 17 00:00:00 2001 From: Samu Date: Thu, 3 Sep 2026 19:28:30 +0200 Subject: [PATCH] docs: record plan 2 post-implementation decisions --- .../plans/2026-08-29-record-shop-frontend.md | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/docs/superpowers/plans/2026-08-29-record-shop-frontend.md b/docs/superpowers/plans/2026-08-29-record-shop-frontend.md index 3f9b77a..2a3be0f 100644 --- a/docs/superpowers/plans/2026-08-29-record-shop-frontend.md +++ b/docs/superpowers/plans/2026-08-29-record-shop-frontend.md @@ -3978,3 +3978,15 @@ Automated tests cannot cover the camera on real hardware. On iOS Safari and Andr 4. Scan an unlisted barcode — "Nothing found" → manual search escape hatch works 5. Deny camera permission once — denial guidance shows, app recovers after allowing + reload 6. Library grid scrolls smoothly with ~200 items; rip-status dots are accurate against your Subsonic server + +--- + +## Post-implementation decisions (recorded at final review) + +Deferred to a follow-up (conscious product call, not oversights): + +- **Library sync control + Subsonic-unreachable banner on Library** — spec offers "Settings *or* Library"; implemented in Settings only. Library stays a pure browse view. +- **Persistent Discogs-token banner on Library** — token errors surface as full-screen states in the Scan/Add flows instead (incl. a dedicated invalid-token screen). +- Minor polish (import-style unification, dead context exports, rip-dot a11y, Library loading state, StrictMode double-fetch, candidate `country` display, camera in-place retry) — fold into the next plan's first touch of these files. + +Landed as final-review fixes: Reset-to-auto in both rip branches, visible mutation failures on ItemPage, distinct invalid-token error screen.